search

script-solution / Boardsolution

An open-source discussion board written in PHP.
GNU General Public License v2.0
6 stars 0 forks source link

ip-log with 0 days should save nothing #46

Closed Rafioso closed 11 years ago

Rafioso commented 11 years ago

For now, if the user set 0 days in the settings for the ip-log, BS still save data into the DB. The IP-Delete-Task run by default every seven days. This means, that the data will be saved for seven days, not until then it'll be deleted. This can be irritating for the user. Should this be changed?

0 day = no save of any data 1 day = delete-task should also been changed to 1 day

What do you think?

hrniels commented 11 years ago

Yes, IMO the current approach is a bit strange. I would also opt for disabling the IP log when 0 days are set. This should also be mentioned in the description of the setting. But I think we should keep the setting and the delete-task independent of each other. Changing the delete-task by the setting would be unintuitive, I think. And the user can easily change the interval of the task as he likes himself. But we should definitely mention that in the description of the setting as well.

Unfortunatly, the IP blockings are implemented by the same mechanism. So, the user would break them if he disabled the IP log. But I don't see a good way of preventing that :/

Rafioso commented 11 years ago

"Unfortunatly, the IP blockings are implemented by the same mechanism. So, the user would break them if he disabled the IP log. But I don't see a good way of preventing that :/"

That's not true. Disabling the IP-Log has no effect to the ban system, because the ban system stores the IP in a separate table (_banlist) and has nothing todo with the table _log_ips.

hrniels commented 11 years ago

I didn't speak of the ban system, but of the IP blockings. For example, that you can't post multiple times within e.g. 30 seconds (with the same IP). This would stop to work if we used "0 days = no logging at all".

Rafioso commented 11 years ago

Oh sorry...

hrniels commented 11 years ago

hm, why does it fix the issue?

Rafioso commented 11 years ago

It doesn't.... it was a fix of another issue. But i restored the file from local history and so the fix of the issue has been reset... see cc07ca9 of the close-commit