script-solution / Boardsolution

An open-source discussion board written in PHP.
GNU General Public License v2.0
6 stars 0 forks source link

E-Mail notification to subscriber after moved topic to an intern forum #54

Closed Rafioso closed 11 years ago

Rafioso commented 11 years ago

Well, after moving an topic to an intern forum, the subscribers are still receiving the E-Mail notifications, although they have no rights to the new forum - and yes, with the text of the post, if the subscribers profile setting permits.

Solution Nr. 1: While moving -> check if subscribers has access to the new forum, if not, delete the subscription. Negative: If this is only an temp-location, the subscription get lost.

Solution Nr. 2: While sending E-Mails -> Check if the subscriber has access to the board. Negative: Subscription-List grows up... but i think, thats no serious problem.

So i prefer solution 2.

hrniels commented 11 years ago

Yes, I also think that solution 2 is better here. Because with 1 you would also have to delete subscriptions if the "intern-status" of a forum is changed in the ACP. Which is bad if the admin just changes that for testing purposes and looses all subscriptions because of that. Additionally, one might specify who has access to the forum not at once but step by step with saving in between. So, at what point should the subscriptions be adjusted? Therefore, solution 2 seems to be really less problematic here.