search

scriptcs-contrib / scriptcs-webapi

Script pack for web api
Other
24 stars 8 forks source link

Fix for scriptcs 0.15.0 #20

Closed adamralph closed 8 years ago

adamralph commented 9 years ago

Currently the script pack insists an a Common.Logging.ILog being injected but in scriptcs 0.15 we do not, and cannot, register that type in the container, since then the container will not be able to pick a constructor for various types which have both a Common.Logging.ILog overload and a ScriptCs.Contracts.ILogProvider overload.

After the scriptcs 0.15.0 release, the script pack should be upgraded to the 0.15.0 binaries and insist on a ScriptCs.Contracts.ILogProvider being injected instead.

tmedanovic commented 8 years ago

@adamralph Are there any plans to fix this some time soon?

adamralph commented 8 years ago

@tmedanovic I see you've gone ahead and fixed it :+1:

Now you just have to persuade @glennblock to release it :wink: