Exit codes from scriptcs.exe are not propagated

adamralph commented 9 years ago

It seems as though svm always returns a zero exit code, even if scriptcs.exe returns something else.

This tripped me up to today whilst writing a script pack test automation app.

paulbouwer commented 9 years ago

Fixed in ebd9aecd30edd66d5920a5234d5f398d50e7e9b9. It was only an issue in the Windows version, but has also been tested on Linux.

c:\ > scriptcs a.csx
ERROR: Could not find file 'C:\a.csx'. - 'C:\a.csx'.

c:\ > echo %errorlevel%
1

c:\> scriptcs -v
               _       _
 ___  ___ _ __(_)_ __ | |__ ___ ___
/ __|/ __| '__| | '_ \| __// __/ __|
\__ \ (__| |  | | |_) | |_| (__\__ \
|___/\___|_|  |_| .__/ \__\\___|___/
                |_| Version: 0.14.0

c:\ > echo %errorlevel%
0

paul@ubuntu:~$ scriptcs a.csx
ERROR: Could not find file "/home/paul/a.csx". - '/home/paul/a.csx'.

paul@ubuntu:~$ echo $?
1

paul@ubuntu:~$ scriptcs -v
               _       _
 ___  ___ _ __(_)_ __ | |__ ___ ___
/ __|/ __| '__| | '_ \| __// __/ __|
\__ \ (__| |  | | |_) | |_| (__\__ \
|___/\___|_|  |_| .__/ \__\\___|___/
                |_| Version: 0.14.0

paul@ubuntu:~$ echo $?
0

adamralph commented 9 years ago

:+1: great work @paulbouwer

I also retried my use case and 0.4.1 fixed it for me.

adamralph commented 9 years ago

That error message from scriptcs.exe is, er, interesting https://github.com/scriptcs/scriptcs/issues/1010

paulbouwer commented 9 years ago

Yes - it is ... confusing :smile:

adamralph commented 9 years ago

Should be fixed in 0.15

On 03:51, Fri, 3 Apr 2015 Paul Bouwer notifications@github.com wrote:

Yes - it is ... confusing [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/scriptcs-contrib/svm/issues/67#issuecomment-89116494.

scriptcs-contrib / svm

Exit codes from scriptcs.exe are not propagated #67