search

scriptcs-contrib / svm

scriptcs version manager
Apache License 2.0
43 stars 13 forks source link

Updated regex for finding junction targets #78

Closed ryanrousseau closed 8 years ago

ryanrousseau commented 8 years ago

The previous regex pattern matched all lines from the dir command causing all installs from the file system to display the directory of the first one in the list.

The changes were to use $() instead of ${} for the string interpolation and to add a space between the item base name and the [] containing the target directory.

I tested it with my installs referenced in #77 and it is working locally.

Fixes #77

ryanrousseau commented 8 years ago

Sorry - submitted too early and targeted master instead of dev. Haven't had enough coffee yet. I'll resend to the correct branch.

ryanrousseau commented 8 years ago

Reopened - thanks @paulbouwer!

paulbouwer commented 8 years ago

Thanks again @ryanrousseau - apologies for taking so long to merge your PR in.