search

scriptdev2 / scriptdev2-cata

ScriptDev2 for Cataclysm
http://www.scriptdev2.com
GNU General Public License v2.0
14 stars 19 forks source link

Auriaya - Feral Defender. #24

Open ghost opened 9 years ago

ghost commented 9 years ago

Welcome script of the boss is working fine, but the script Feral Defender is still not working. https://github.com/scriptdev2/scriptdev2-cata/blob/master/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp#L268 Not working: m_uiReviveDelayTimer for some reason does not start, I want to mention only tested at Cata.

xfurry commented 9 years ago

Ok... I'll retest on Cata then.

ghost commented 8 years ago

I found a bug

uint32 m_uiKilledCount;

Why uint32? Need uint32 m_uiKilledCount; replace on uint8 m_uiKilledCount; ++m_uiKilledCount; not working! Need replace

xfurry commented 8 years ago

uint32 and uin8 doesn't make a difference. uint32 it's the standard type, so that should be fine. Unless we are going negative I can't see any issue in that line.

I think there is a problem with Cata core, rather than script

ghost commented 8 years ago 
I think there is a problem with Cata core, rather than script

Cata nothing to do with the kernel, I tested General Vezax and Freya - works great. There used uint8. This is mistake SD2.

ghost commented 8 years ago

Substitution on uint8 also does not solve the problem. Tested in game.

ghost commented 8 years ago

https://github.com/scriptdev2/scriptdev2-cata/blob/master/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp#L305 I'm not sure, but it can cause blockage?

https://github.com/scriptdev2/scriptdev2-cata/blob/master/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp#L288 Something is does not allow the timer to start.