scripting / a8c-FeedLand-Support

A public repo for discussing FeedLand at A8C.
1 stars 0 forks source link

Feed name in user info page #80

Closed fmfernandes closed 7 months ago

fmfernandes commented 7 months ago

Some users have a blank feed name and some have an undefined as their feed name.

I was able to reproduce the blank feed name by going to my settings screen and changing my feed title to an empty string and clicking on save. This is my user page.

I believe the feed title there should have be the feed title otherwise a default feed text if title is empty.

undefined seems to be the initial state when a user signs up. If the user signs up and check the settings screen, the undefined will be replaced with a blank name.

scripting commented 7 months ago

The default values for the feed title and description are in appPrefs.myFeedTitle and appPrefs.myFeedDescription.

myFeedTitle: "My Feed",
myFeedDescription: "The feed for my FeedLand notes.",

I'm pretty confident that code works, it's been that that way for many years, without error.

It's more likely there was some problem at some point with static storage.

Do you know how long ago the accounts for these users were created?

scripting commented 7 months ago

You can find the declaration for appPrefs at the top of http://scripting.com/code/feedland/home/code.js.

fmfernandes commented 7 months ago

@scripting, I've just signed up on feedland.org with a random email/user and the feed title/description was empty.

The same applies to feedland.com as expected. With a brand new user, this is what I get on the settings:

image

Which is why on the user info page it's undefined.

scripting commented 7 months ago

Interesting. It's happening this way on feedland.org too. Hmm.

scripting commented 7 months ago

@fmfernandes -- what about other settings, are any of them undefined too? mostly they come from the same places.

fmfernandes commented 7 months ago

@scripting, for new users, all of them are empty except for the Linker tab which the value for URL is https://feedland.com/?linkblog=true&. Maybe this has something to do with when we switched to storing prefs in the db instead of S3 storage?

scripting commented 7 months ago

@fmfernandes -- you win 10 points, it's a legit bug, in feedlandHome, which is now fixed.

Do a hard reload, and try it again with a new account.

Thank you.

fmfernandes commented 7 months ago

Fixed!