scripting / river5

A river-of-news RSS aggregator in JS running in Node.
MIT License
428 stars 122 forks source link

Doesn't work with HTTPS #21

Open gka opened 6 years ago

gka commented 6 years ago

the default River layout includes various JavaScript resources via HTTP. These imports fail and throw a mixed-content warning when the river is hosted on HTTPS.

Needless to say, the site is not usable without JavaScript.

Solution would be to either

I would prefer the former because I don't see why my River instance needs to depend on external websites. I assume fargo.io and nodestorage.io belong to Dave Winer, but some day he might decide to give the domains up (fargo.io already shows a retirement page).

scripting commented 6 years ago

I don't have an HTTPS server.

Probably should use a CDN for this.

Have to look into it.

thejeshgn commented 6 years ago

cdnjs ?

scripting commented 6 years ago

@thejeshsg -- I looked around on cdnjs and couldn't find a howto page that explained what you have to do to get a library in their CDN.

scripting commented 6 years ago

This testimonial for jsDeliver sounds interesting.

https://www.quora.com/What-is-the-best-CDN-for-open-source-projects

It can serve from any NPM package.

scripting commented 6 years ago

I like jsDeliver. Here's what I've done so far.

  1. Created a river5 npm package.

  2. Tested that jsDeliver can access it.

https://cdn.jsdelivr.net/npm/river5/river5.js

That's pretty clean.

So what I would have to do if I used this, is create a folder in the repo with the content of all the included files, publish the result on NPM, then change the includes in the default files.

Probably should upload the source for the default files there too.

Then we won't be depending on http://fargo.io/ for the files, which is of course a good thing. ;-)

scripting commented 6 years ago

Now I'm getting an error when I try to access that file.

Package size exceeded the configured limit of 50 MB.

The river5 package isn't even 1MB. Nor is the GitHub repository.

Hard to make sense of that message.

scripting commented 6 years ago

The package was bigger than 50MB. My error.

We are now able to open the test file using jsdelivr.

https://cdn.jsdelivr.net/npm/river5/river5.js

thejeshgn commented 6 years ago

Had not see jsdeliver. It looks good and easy.

scripting commented 6 years ago

Made a lot of progress today on using jsdelivr as the CDN. Should have a release of River5 tomorrow that should be able to run behind HTTPS, and will not use any of my domains for serving code or stylesheets.

scripting commented 6 years ago

Okay the new releases of river5 and davereader are out.

That said, there are still references to fargo.io in the code.

That'll take more time to shake out because this code is shared with my other projects.

But the main files are now in jsdelivr.

Please update your River5 and watch for problems.

mistersugar commented 6 years ago

Not working for me. Here's what I did. Did I do the right sequence?

I stopped river5.js

ran npm update but got an error that node-gyp rebuild failed on my system. Screenshot attached.

screen shot 2018-04-14 at 11 59 47 am

tried to restart river5 but the process stops immediately.

scripting commented 6 years ago

That's a problem with the previous release, not this one, that's when iconv was introduced.

I don't know what the messages mean, we have to get other people to look at it.

On Saturday, April 14, 2018, Anton Zuiker notifications@github.com wrote:

Not working for me. Here's what I did. Did I do the right sequence?

I stopped river5.js

ran npm update but got an error that node-gyp rebuild failed on my system. Screenshot attached.

[image: screen shot 2018-04-14 at 11 59 47 am] https://user-images.githubusercontent.com/3846301/38770391-7d4c6c1a-3fe0-11e8-9ed8-90d31d609fc4.png

tried to restart river5 but the process stops immediately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/21#issuecomment-381342281, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9Oxm5Bqomnu044Mm7KEqrKrZ42660ks5toia3gaJpZM4TMDh8 .

-- Typed on an iPad with fat fingers.

scripting commented 6 years ago

This suggests doing it again.

https://stackoverflow.com/questions/30744964/what-does-the-elifecycle-node-js-error-mean

Also try deleting the npm_modules folder and doing npm install.

On Saturday, April 14, 2018, Dave Winer dave@smallpicture.com wrote:

That's a problem with the previous release, not this one, that's when iconv was introduced.

I don't know what the messages mean, we have to get other people to look at it.

On Saturday, April 14, 2018, Anton Zuiker notifications@github.com wrote:

Not working for me. Here's what I did. Did I do the right sequence?

I stopped river5.js

ran npm update but got an error that node-gyp rebuild failed on my system. Screenshot attached.

[image: screen shot 2018-04-14 at 11 59 47 am] https://user-images.githubusercontent.com/3846301/38770391-7d4c6c1a-3fe0-11e8-9ed8-90d31d609fc4.png

tried to restart river5 but the process stops immediately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/21#issuecomment-381342281, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9Oxm5Bqomnu044Mm7KEqrKrZ42660ks5toia3gaJpZM4TMDh8 .

-- Typed on an iPad with fat fingers.

-- Typed on an iPad with fat fingers.

scripting commented 6 years ago

Anton, was the problem resolved?

mistersugar commented 6 years ago

Not yet. Started in on it, but had to break for family activities. Was thinking to do it now, but feeling tired and figure better to try tomorrow when I'm clear headed. Will report progress/success in the morning, with luck.


Anton Zuiker 919.923.9491

Blogging again at zuiker.com

On Sat, Apr 14, 2018 at 9:33 PM, Dave Winer notifications@github.com wrote:

Anton, was the problem resolved?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/21#issuecomment-381373448, or mute the thread https://github.com/notifications/unsubscribe-auth/ADqwnbZdMWo8pvA5nYfU5QUl2xVxcbcJks5toqNegaJpZM4TMDh8 .

mistersugar commented 6 years ago

Still having trouble. Suspect this might be a permissions issue on my server. Have submitted a ticket.

mistersugar commented 6 years ago

My webhost assigned execute permissions to that file (river5/lib/node_modules/npm/bin/node-gyp-bin/node-gyp), and I was able to npm update and then start river5.js with forever. The Duke River of News is back up and flowing at http://river5.dukeriver.co/

scripting commented 6 years ago

To which file??

On Mon, Apr 16, 2018 at 10:42 AM Anton Zuiker notifications@github.com wrote:

My webhost assigned execute permissions to that file, and I was able to npm update and then start river5.js with forever. The Duke River of News is back up and flowing at http://river5.dukeriver.co/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/21#issuecomment-381623181, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9O1LlZXJN5t5hfydCQh523HeMI1Q8ks5tpK25gaJpZM4TMDh8 .

mistersugar commented 6 years ago

This was the file that needed permissions changed by my webhost:

river5/lib/node_modules/npm/bin/node-gyp-bin/node-gyp

scripting commented 6 years ago

I see. That makes sense.

On Mon, Apr 16, 2018 at 10:54 AM Anton Zuiker notifications@github.com wrote:

This was the file that needed permissions changed by my webhost:

river5/lib/node_modules/npm/bin/node-gyp-bin/node-gyp

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/21#issuecomment-381627634, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9OxMHCbsvacFdoFN1N4IepHeeQhrZks5tpLCHgaJpZM4TMDh8 .

ChristophKnopf commented 6 years ago

Hi Dave, hi Anton, I checked all paths and the permissions for node-gyp but couldn't find missing execute rights here.

$ ll .npm-global/lib/node_modules/npm/bin/node-gyp-bin/
drwxr-xr-x 2 user user 4096 Mär 12 10:25 .
drwxr-xr-x 3 user user 4096 Mär 12 10:25 ..
-rwxr-xr-x 1 user user  172 Jan  1  1970 node-gyp
-rwxr-xr-x 1 user user  148 Jan  1  1970 node-gyp.cmd

So that seems not to be my problem. If I find a solution I will post it here.