Some include files still point to http://fargo.io

[SparkyT]

The following 4 files in the repo and on jsdelivr.net appear to have document.write calls to add scripts from http://fargo.io, not the new //cdn.jsdelivr.net locations causing https instances of river5 to not work as expected

• includes/basicincludes2/beep.js
• includes/riverBrowserIncludes/emojify.js
• includes/riverBrowserIncludes/riverbrowser.js
• includes/misc/riverbrowser.js

[scripting]

In what way do they make it not behave?

On Tuesday, April 24, 2018, SparkyT notifications@github.com wrote:

The following 4 files in the repo and on jsdelivr.net appear to have document.write calls to add scripts from http://fargo.io, not the new // cdn.jsdelivr.net locations causing https instances of river5 to not work as expected

• includes/basicincludes2/beep.js
• includes/riverBrowserIncludes/emojify.js
• includes/riverBrowserIncludes/riverbrowser.js
• includes/misc/riverbrowser.js

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9O3XXlze_-hnIFsp3JedhBvEYSQwJks5tr6wngaJpZM4TiiW6 .

-- Typed on an iPad with fat fingers.

[SparkyT]

Good point - the document.write puts references to http resources which on https instances of river5 results in mixed content warnings and them being blocked. River5 then doesn't display rivers (see screenshot)

[scripting]

Now I understand.

I can't test this stuff myself because I don't have an HTTPS server to deploy to.

I'll work on this today. I had planned to get to this eventually. The problem is there are other apps I have that depend on these files, and depend on the document.write statements.

River5 doesn't depend on them, so I figured the document.writes would generate warnings, but they wouldn't stop the app from running. Now I see it's otherwise.

It would be helpful if you could quickly test versions, then I can iterate.

Back in a bit with something for you to try.

On Wed, Apr 25, 2018 at 3:41 AM SparkyT notifications@github.com wrote:

Good point - the document.write puts references to http resources which on https instances of river5 results in mixed content warnings and them being blocked. River5 then doesn't display rivers (see screenshot) [image: river5-docwrite] https://user-images.githubusercontent.com/4244537/39232179-5b420012-4864-11e8-9c42-1bc8f24d54e7.PNG

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scripting/river5/issues/23#issuecomment-384190422, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9O-F9Vmze6WEk3_RkqCcZdoPe3T1Sks5tsCiXgaJpZM4TiiW6 .

[scripting]

OK, to do this final (I hope) pass, I've set up a virgin River5 on my desktop.

I'm looking at the home page in the browser. These are the files that are included at the top of the page.

//cdn.jsdelivr.net/npm/river5/includes/basicincludes2/alertdialog.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/app.css //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/app.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/appprefs.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/askdialog.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/beep.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/bootstrap.css //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/bootstrap.min.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/confirmdialog.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/font-awesome.min.css"/> //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/ga.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/jBeep.min.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/jquery-1.9.1.min.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/menus.css //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/menus.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/strftime.js //cdn.jsdelivr.net/npm/river5/includes/basicincludes2/utils.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/api.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/dateFormat.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/emojify.css //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/emojify.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/markdownConverter.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/outlinebrowser.js //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/riverbrowser.css //cdn.jsdelivr.net/npm/river5/includes/riverBrowserIncludes/riverbrowser.js //fonts.googleapis.com/css?family=Rancho //fonts.googleapis.com/css?family=Ubuntu

So these all look cool. The question is what document.writes do each of them trigger?

[scripting]

BTW, I have steps-to-reproduce, and through the magic of jsdelivr, I believe I will be able to fix this problem without you having to test.

I noticed the URL in your screen shot, a familiar one, with https instead of http.

https://newriver5.glitch.me/

Boom, that page doesn't load and when I look at the console there are the errors.

[scripting]

Here are the files the browser complains about.

http://fargo.io/code/shared/jBeep.min.js 'http://fargo.io/code/emojify/emojify.js 'http://fargo.io/code/node/shared/utils.js 'http://api.nodestorage.io/api.js 'http://fargo.io/cms/dateFormat.js 'http://fargo.io/code/browsers/outlinebrowser.js 'http://counter2.fargo.io:5337/counter http://fargo.io/code/ubuntuFont.css http://fargo.io/code/fontAwesome/css/font-awesome.min.css http://fonts.googleapis.com/css?family=Lora:400,700,400italic,700italic http://fargo.io/code/browsers/riverbrowser.css

[scripting]

@SparkyT -- in order to get this debugged, I need you to do an npm update on the server, to get the latest version of davereader. I just changed the default URL of the homepage and the dashboard page My CDN is being fussy about getting the latest version, this way is fairly foolproof.

Thanks for all your help with this. Very cool. ;-)

[SparkyT]

@scripting - no problem, it's interesting being involved in something that someone else has created.

npm update is done and it looks as though https://newriver5.glitch.me/ is now working.

Given we have the chance now before it is really publicised do you want to change the glitch name from newriver5 to something else?

[scripting]

@sparkyt -- this is great. ;-)

1. Re the glitch name, obviously River5 is the best choice.

2. Has someone already taken that name? If so any chance of getting them to relinquish it?

3. Could you change "World News" to just "World" -- the news part is implicit, and it'll look more balanced if it's shorter.

4. I'm surprised it works. There are still errors which I will fix, in the console. In the meantime it works, which is good. ;-)