Fix new id for General config link in May release

scriptotek / alma-slipsomat

Tool for syncing Alma letters XSL files with a local folder

MIT License

15 stars 10 forks source link

Fix new id for General config link in May release #34

Closed daniels closed 6 years ago

daniels commented 6 years ago

In the May 2018 release of Alma the General configuration menu got a new ID (#CONF_MENU6 instead of #CONF_MENU5). At least that is what I currently see in our sandbox.

This fix probably shouldn't be applied before the release is live in production ...

danmichaelo commented 6 years ago

Thanks, can confirm that it changed. A bit odd. To make it more robust, perhaps we should use

browser.click(By.XPATH, '//*[text() = "General"]')

instead? I think Alma is not localized to other languages?

daniels commented 6 years ago

Unfortunately (no, not really, only in this case) I think the Alma UI is translated to at least French and German.

danmichaelo commented 6 years ago

Slipsomat still looks for the text "Customize Letters" in the next step, so it probably won't work with non-English anyways…

Perhaps @th122 knows something about the German version? Is it used at DNB?