search

scriptotek / mc2skos

Command line script for converting Marc21 Classification and Authority records to SKOS/RDF
The Unlicense
21 stars 4 forks source link

Add option --webdewey and guess output format from filename #33

Closed nichtich closed 7 years ago

nichtich commented 7 years ago

I also extended the README in branch https://github.com/gbv/mc2skos/tree/readme but not mentioning option --webdewey yet.

codecov-io commented 7 years ago

Codecov Report

Merging #33 into master will decrease coverage by 0.76%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   79.09%   78.32%   -0.77%     
==========================================
  Files           5        5              
  Lines         684      692       +8     
==========================================
+ Hits          541      542       +1     
- Misses        143      150       +7
Impacted Files Coverage Δ
mc2skos/mc2skos.py 53.23% <33.33%> (-1.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8e8340...523cf91. Read the comment docs.

danmichaelo commented 7 years ago

Thanks! I can also document the --webdewey option.

danmichaelo commented 7 years ago

Btw. the --notes flags was added because I'm not allowed to publish those for WebDewey. But for a general tool it probably makes more sense to include notes by default and have a --exclude-notes flag for the WebDewey case.

nichtich commented 7 years ago

Thanks! I'd prefer --no-notes instead of --exclude_notes but nevermind.