Closed nichtich closed 6 years ago
Agree that the solution is not a good one. A better solution could be to only add $c
if it follows $a
. Then the test should still pass without any break/continue stuff.
But if the example in testComplexTableEntryWithUndocumentStuff
is really invalid MARC21 Classification, it would also be better to have it fixed and remove the test. I will start asking the NO editorial team what they think about the example.
The example used in the test has since been fixed, so I think it's safe to remove this. And if I find new cases, I can try a better fix like adding $c
only if it follows `$a
In https://github.com/scriptotek/mc2skos/blob/master/mc2skos/record.py#L513 processing of field 153 is stopped when a caption is found. I have some classification records with subfields
j
followed bye
so they cannot be processed. I changed in my branch toand this passes current test. But why
break
at all? Could we change thebreak
tocontinue
and remove the test?