search

scriptotek / mc2skos

Command line script for converting Marc21 Classification and Authority records to SKOS/RDF
The Unlicense
21 stars 4 forks source link

Add skosify #47

Closed nichtich closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #47 into master will increase coverage by 1.04%. The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   78.73%   79.78%   +1.04%     
==========================================
  Files           5        6       +1     
  Lines         710      732      +22     
==========================================
+ Hits          559      584      +25     
+ Misses        151      148       -3
Impacted Files Coverage Δ
mc2skos/mc2skos.py 56.8% <63.15%> (+2.74%) :arrow_up:
mc2skos/reader.py 94.44% <94.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 546a68c...eaa0550. Read the comment docs.

danmichaelo commented 6 years ago

Thanks! The reason I removed graph=Graph() from the default arguments of process_records() is because of this: http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments . Not very important in our case since we always pass an argument, but good to know.