scriptotek / mc2skos

Command line script for converting Marc21 Classification and Authority records to SKOS/RDF
The Unlicense
21 stars 4 forks source link

Support mapping from classification records #52

Closed nichtich closed 6 years ago

nichtich commented 6 years ago

Move code for extraction of mappings from 7XX from authority records to all types of records. This required addition of vocabulary codes to mc2skos/vocabularies.yml. Tested with an RVK record mapped to GND.

This fixes feature request #51.

codecov-io commented 6 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.03%. The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   79.54%   79.57%   +0.03%     
==========================================
  Files           6        6              
  Lines         743      754      +11     
==========================================
+ Hits          591      600       +9     
- Misses        152      154       +2
Impacted Files Coverage Δ
mc2skos/record.py 88.1% <91.17%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c472cf5...3ecee88. Read the comment docs.

nichtich commented 6 years ago

@danmichaelo So make this a new issue, independent from this pull request, so at least existing records can be converted?

danmichaelo commented 6 years ago

Yeah, agree.