search

scriptotek / php-marc

Simple interface for working with MARC records using the File_MARC package
MIT License
51 stars 11 forks source link

Make getSubfieldValues public. #21

Closed rudolfbyker closed 4 years ago

rudolfbyker commented 4 years ago

It would be very useful for me to be able to access getSubfieldValues from outside the object.

codecov-commenter commented 4 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     84.44%   84.44%           
  Complexity      272      272           
=========================================
  Files            24       24           
  Lines           598      598           
=========================================
  Hits            505      505           
  Misses           93       93
Impacted Files Coverage Δ Complexity Δ
src/Fields/Field.php 95.08% <100.00%> (ø) 29.00 <4.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cac7b94...7ada8ff. Read the comment docs.

danmichaelo commented 4 years ago

No prob! Let me know if you need a new release.

rudolfbyker commented 4 years ago

Wow, thanks for the quick merge! Regarding the release: Let met develop my project some more. I'll probe you for a release when it's closer to completion. For now, I can get away with using the specific commit in composer.json :)

rudolfbyker commented 4 years ago

Regarding the release, I think now would be a good time, if you are willing, to make a new release. I would greatly appreciate it.

danmichaelo commented 4 years ago

That's really nice of me to promise a release, and then go off the radar for a month 😅 Sorry about that, I realise I actually need to unsubscribe a few things to clean up my GitHub feed to a point where I actually start looking at it again :)

Anyways, 2.2.0, here we go.