scristalli / sql-developer-keepalive

MIT License
149 stars 21 forks source link

New PollIntervalDialog and fix for infinite loop of pings when exception occurs #4

Closed eftewuer closed 9 years ago

eftewuer commented 10 years ago

New dialog for asking for pull interval timeout with filter so only numbers can be inserted into the textfield.

Corrected problem with infinite loop when exception occurs when keepalive is started. There was no Thread.sleep() call in the last catch clause which caused hundreds/thousands ping requests per second.

Added dependency to oracle.db-api because without it JDeveloper 12.1.3.0.0 complains about missing file for class DBException.

Project files were automatically updated by JDeveloper to its new version so comitted them to the repo.

scristalli commented 10 years ago

Thanks eftewuer for your pull request. Just one day or two to view the changes and test, and I will merge it if substantial improvements have been made (it already looks like so).

scristalli commented 9 years ago

The pull request has been merged. Release 1.1 will be based on the changes brought.