scrivanolabs / ScrivanoForLinux

Scrivano is a notetaking application for handwritten notes.
93 stars 2 forks source link

Importing pdf flips orientation #18

Open henrispriet opened 6 months ago

henrispriet commented 6 months ago

I am using version 0.18.14. When I make a new file and then import a pdf, the orientation of the file is flipped, regardless of whether the pdf is vertical or horizontal.

new file orientation | pdf orientation | orientation after import
---------------------+-----------------+-------------------------
vertical             | vertical        | horizontal
vertical             | horizontal      | horizontal
horizontal           | vertical        | vertical
horizontal           | horizontal      | vertical
scrivanolabs commented 6 months ago

Hi thanks for the feedback. I think the problem you've reported is due to the fact that when creating a new PDF file into an empty PDF document, Scrivano automatically resizes the document size to match the size of the first page of the document. Indeed if say you import a landscape A4 page, then Scrivano will match the size of the A4 page (although it doesn't match the orientation).

I guess, one possible solution to this problem would be to introduce a small dialog when importing that asks the user whether they want this behaviour or not.

henrispriet commented 6 months ago

I think it would make the most sense if the document would adapt to the orientation of the pdf by default. That way one presumable wouldn't have to worry about whether they had created the doc in horizontal or vertical orientation (unless I'm missing something). Any imported pdf would just display correctly.

Anyway, I assumed this was a bug because I definitely remember this behaviour being different in previous versions (idk how far back). I think back then, the doc didn't resize. So for presentation slides, I would always have to open the document as horizontal.

scrivanolabs commented 6 months ago

I think it would make the most sense if the document would adapt to the orientation of the pdf by default.

Yes, that's a good point. I'll add it to my todo list.