search

scrive / log

Structured logging solution.
https://hackage.haskell.org/package/log-base
BSD 3-Clause "New" or "Revised" License
35 stars 7 forks source link

Fix compilation for new aeson-pretty + misc fixes #2

Closed jonathanjouty closed 8 years ago

jonathanjouty commented 8 years ago

Actually, version of log on Hackage is 0.5.2. I thought this was just due to Andrzej bumping maintainers list, but there are more differences which were never pushed here :/

Closing request as those should be pushed first.

jonathanjouty commented 8 years ago

First merge changes here: https://github.com/scrive/log/pull/3

Then I will fix conflicts so that this can be merged.

jonathanjouty commented 8 years ago

Rebased on branch dev-jonathan-push-0.5.2, so should merge cleanly after #3 is merged.

mariuszrak commented 8 years ago

Build for me on empty sandbox - if removed cabal.conf - with ghc-7.10. Code looks find, same for other PR (https://github.com/scrive/log/pull/3)

johanhil commented 8 years ago

I also approve.

Den 18 jul 2016 16:43 skrev "mariuszrak" notifications@github.com:

Build for me on empty sandbox - if removed cabal.conf - with ghc-7.10. Code looks find, same for other PR (#3 https://github.com/scrive/log/pull/3)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scrive/log/pull/2#issuecomment-233348855, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQzLYExqGjhesAlZJ6AKZbCAvaoytb4ks5qW5CjgaJpZM4JOniN .

jonathanjouty commented 8 years ago

Thank for @johanhil for the seal of approval 🐳