search

scrive / log

Structured logging solution.
https://hackage.haskell.org/package/log-base
BSD 3-Clause "New" or "Revised" License
35 stars 7 forks source link

Replace deprecated "string" type in ES V5 #45

Closed linearray closed 5 years ago

linearray commented 6 years ago

According to the section "How to migrate" in https://www.elastic.co/blog/strings-are-dead-long-live-strings and the information here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/mapping-index.html this should be equivalent to the current behaviour.

Closes #44

phadej commented 6 years ago

The log-elasticsearch-copy.sh will undo this. Either we should drop V1 or modify that script too.

linearray commented 6 years ago

What is that script used for? I don't see it being called anywhere.

phadej commented 6 years ago

it copies V1 contents to V5 and renames V1 to V5 as all differences are somewhere in bloodhound

linearray commented 6 years ago

Oh, so the point is to only maintain the V1 versions, run the script manually and commit the output. That took a while to grasp.

Sure, I can edit the script to not overwrite V5.hs, if that is acceptable.

phadej commented 6 years ago

Could you rather try if sed 's/"string"/"text"/' does right thing?

linearray commented 6 years ago

Hey I think you're right. index even defaults to true for text so we should be good. However, I can't really test it against ES right now :(

linearray commented 6 years ago

I spent some time testing this in a VM and in fact this patch is even required to use the current ES 6.5. Seems to work fine.

linearray commented 5 years ago

Is there anything else that needs to be done before this can be merged?

23Skidoo commented 5 years ago

LGTM, can you please add a changelog note?

23Skidoo commented 5 years ago

Merged, thanks! Will cut a release later today or tomorrow.

23Skidoo commented 5 years ago

Sorry, completely forgot about this. log-elasticsearch-0.10.0.1 is now out.