search

scrivo / highlight.php

A port of highlight.js by Ivan Sagalaev to PHP
BSD 3-Clause "New" or "Revised" License
695 stars 45 forks source link

demo/line-numbers.php - style changed #32

Closed truefriend-cz closed 5 years ago

truefriend-cz commented 5 years ago

If i use demo/line-numbers.php and set css is Dark background style then no show background Dark and text formatting missed (bad overflow, spacing, etc.) (text highlighting is ok only) .

allejo commented 5 years ago

Would you mind posting a snippet of the code you’re trying out?

Sounds like a CSS question, so I think your text is just blending into the dark background because the font color is black. If you set the font color to white or another light color, that should prevent it from blending into the dark background.

Possibly something like this?

body {
  background-color: #252525;
  color: white;
}

Additionally, if you're going to go with a dark theme, I'd recommend you pick out a dark color scheme (e.g. a11y-dark.css) so the highlights can appear with enough constract.

allejo commented 5 years ago

I'm going to close this issue since it's not directly related to this library's functionality. Feel free to keep asking questions related to this and I'll do my best to help out as I can.