search

scroll-tech / ceno

Accelerate Zero-knowledge Virtual Machine by Non-uniform Prover Based on GKR Protocol
Apache License 2.0
59 stars 10 forks source link

Port Goldilock from Plonky2 with proper field arithmetics wrapper #483

Open hero78119 opened 1 month ago

hero78119 commented 1 month ago

As current Goldilock repo is out from personal repo from patching repo both lack of following up activities and probably no audit.

One possible solution is to switch to Plonky2 Goldilocks with more mature optimisation, e.g. avx

matthiasgoergens commented 1 month ago

Plonky2 has pretty decent code overall. Keep in mind that when I used plonky2 in the past, I did not see any benefit from avx (and the plonky2 authors weren't surprised). That might be because it's already pretty well optimised even without avx, or because they missed some avx optimisations. I'm not sure.

https://github.com/0xPolygonZero/plonky2/pull/1621 might be interesting to watch!

matthiasgoergens commented 1 month ago

Until we move to plonky2, we can at least use a scroll-owned Goldilocks repo. See https://github.com/scroll-tech/ceno/pull/459