search

scroll-tech / ceno

Accelerate Zero-knowledge Virtual Machine by Non-uniform Prover Based on GKR Protocol
Apache License 2.0
53 stars 6 forks source link

Remove unimplmented and unused functions #576

Closed matthiasgoergens closed 2 weeks ago

hero78119 commented 2 weeks ago

LGTM! Just a suggestion: why clippy not capture this :) ? is it because there lack of some setting?

matthiasgoergens commented 2 weeks ago

LGTM! Just a suggestion: why clippy not capture this :) ? is it because there lack of some setting?

It's because clippy can't know whether some other project uses our pub functions. So all pub functions are considered used by default.

(I wonder if there's a setting we can use to tell clippy that not all pub functions should automatically be counted as used.)