scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
470 stars 271 forks source link

feat(rpc): add getTxByTxTrace api, used for ccc testing & debugging #1026

Closed lispc closed 1 week ago

lispc commented 1 week ago

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?

lispc commented 1 week ago

this pr does not change any imports..? why 'goimports -local github.com/scroll-tech/go-ethereum/ -w .' is not ok...

colinlyguo commented 1 week ago

this pr does not change any imports..? why 'goimports -local github.com/scroll-tech/go-ethereum/ -w .' is not ok...

might be the golang version of CI (encountered the same issue before). btw, what is the original motivation to increase version 1.21?