scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
493 stars 276 forks source link

feat: try to avoid reading mempool under load #1047

Closed omerfirmak closed 2 months ago

omerfirmak commented 2 months ago

1. Purpose or design rationale of this PR

In the cases where we close a block due to some limit other than the timeout, there is a high chance that worker already has a bunch of txns at hand that it can include in the next block.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?

omerfirmak commented 2 months ago

Would this optimization lead to "not full" blocks from time to time?

Yes, there is a risk of decreasing the overall block space utilization.