scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
470 stars 271 forks source link

calculate tx the lifecycle duration #839

Closed georgehao closed 3 weeks ago

georgehao commented 2 months ago

1. Purpose or design rationale of this PR

Calculate the tx median lifecycle duration.

Background is here: https://www.notion.so/scrollzkp/7ba4e2226275414692228f6332d85621?v=d8d35fc59bae4ad1acf48fdfc616934e&p=2a41bd0b70d54211a7b34e1ea766b14a&pm=s

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?

HAOYUatHZ commented 4 weeks ago

here we don;t distinguish the "end time" for

  1. tx is included
  2. tx is dropped

then how can it serve your need? we wouldn't know a "lifecycle duration" is for being included or being dropped

image
georgehao commented 4 weeks ago

here we don;t distinguish the "end time" for

  1. tx is included
  2. tx is dropped

then how can it serve your need? we wouldn't know a "lifecycle duration" is for being included or being dropped image

tx is included we can know this, i think tx is dropped yes, can't get this. this will affect the p90 statistics, for p50 it's ok