scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
470 stars 271 forks source link

refactor(trace): clean outdated fields #842

Closed lispc closed 1 month ago

lispc commented 2 months ago

1. Purpose or design rationale of this PR

  1. collect accessed bytecodes to top level inside BlockTrace struct.
  2. so we can remove ExtraData field
  3. and we can disable prestateTracer too

This PR can work well with deployed curie provers ( >= v0.11.4).

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?

lispc commented 2 months ago

@omerfirmak can you merge instead of rebase-and-force-push next time? unfriendly for branch management..

lispc commented 1 month ago

@omerfirmak need another review