scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
458 stars 262 forks source link

feat: make descartes a timestamp based fork #852

Closed omerfirmak closed 1 month ago

omerfirmak commented 1 month ago

1. Purpose or design rationale of this PR

simply changes IsDescartes to check the block time instead of height. I knowingly left out compatibility checks for timestamp based forks, since they will come with sync to upstream anyways.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?