scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
458 stars 262 forks source link

feat(rollup_sync_service): handle multiple batches in `FinalizeBatch` event #865

Closed amoylan2 closed 3 weeks ago

amoylan2 commented 4 weeks ago

1. Purpose or design rationale of this PR

FinalizeBatch event will influence one or more batches

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?

amoylan2 commented 4 weeks ago

LGTM. does this pr also need to bump version?

A reminder of features left (in other PRs):

  1. codecv3 when calculating batch hashes after Darwin.
  2. adding new unit tests after the contract and rollup-relayer are ready (fetching test cases by running a local testnet).

Let's open another pr to implement the changes related to codecv3

colinlyguo commented 4 weeks ago

the feature is not a full set of new features to be released. do we need to bump version as well? or move the related changes into an upgrade4 branch? cc @Thegaram @georgehao

Thegaram commented 4 weeks ago

the feature is not a full set of new features to be released. do we need to bump version as well? or move the related changes into an upgrade4 branch? cc @Thegaram @georgehao

So we will need one more PR to add codecv3, right?

I think we can merge it to develop (but make sure it's backward compatible). And let's bump version so that we can test this on our nodes first.