scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
458 stars 262 forks source link

fix: return early as expected when engine.Prepare fails #886

Closed omerfirmak closed 2 weeks ago

omerfirmak commented 2 weeks ago

1. Purpose or design rationale of this PR

when called with common.WithTimer, early return in the error branch only returns from the delegate function passed to common.WithTimer. We need to return early from startNewPipelineentirely.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?