search

scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol
GNU Lesser General Public License v3.0
494 stars 276 forks source link

fix(rollup-verifier): decode commitBatchWithBlobProof calldata #896

Closed colinlyguo closed 3 months ago

colinlyguo commented 3 months ago

1. Purpose or design rationale of this PR

This PR fixes the bug that current rollup verifier cannot decode commitBatchWithBlobProof's calldata.

if method.Name == "commitBatch" {
  // decode block ranges
} else if method.Name == "commitBatchWithBlobProof" {
  // decode block ranges
}

This also adds unit tests fetched from local testnet commitBatchWithBlobProof transactions.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

3. Deployment tag versioning

Has the version in params/version.go been updated?

4. Breaking change label

Does this PR have the breaking-change label?