refactor: use new codec interfaces

scroll-tech / go-ethereum

Scroll's fork of the official Go implementation of the Ethereum protocol

GNU Lesser General Public License v3.0

494 stars 276 forks source link

refactor: use new codec interfaces #997

Closed colinlyguo closed 3 weeks ago

colinlyguo commented 2 months ago

1. Purpose or design rationale of this PR

Based on codec repo's simple factory pattern version (also after refactoring).

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[x] refactor: A code change that doesn't fix a bug, or add a feature, or improves performance

colinlyguo commented 3 weeks ago

Shouldn't this be better based on top of syncUpstream/active branch?

makes sense. this pr is opened before activating the syncUpstream/active branch, will open another PR based on syncUpstream/active branch instead.

colinlyguo commented 3 weeks ago

new incremental updates will be merged to syncUpstream/active branch, thus closing this PR.