search

scroll-tech / halo2-snark-aggregator

halo2 ecc circuit
Apache License 2.0
114 stars 24 forks source link

`sample_run` fails with `entered unreachable code` for the `zkevm` sample #18

Closed mr-ma closed 2 years ago

mr-ma commented 2 years ago

I am on the main branch (commit 58cb081). And I follow the instruction for the zkevm sample. It works fine for the sample_setup step. But it fails for sample_run:

cd /home/halo2-snark-aggregator/halo2-snark-aggregator-sdk
mkdir output
cargo run --example zkevm --release -- --command sample_run --nproofs 2 --folder-path ./output

Results in:

    Finished release [optimized] target(s) in 0.49s
     Running `/home/halo2-snark-aggregator/target/release/examples/zkevm --command sample_run --nproofs 2 --folder-path ./output`
thread 'main' panicked at 'internal error: entered unreachable code', /usr/local/cargo/git/checkouts/halo2-f8a0b3a217d7c8ca/4112958/halo2_proofs/src/plonk/evaluation.rs:356:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
xgaozoyoe commented 2 years ago

Fixed in add estimate profile for circuits #17. If we can load vkey from file instead of generating it again due to issue see https://github.com/zcash/halo2/issues/449, then verify circuit doesn't depend on concret circuit anymore.