search

scroll-tech / halo2-snark-aggregator

halo2 ecc circuit
Apache License 2.0
114 stars 24 forks source link

verifier circuit vkey read / write not working #24

Open jonathanpwang opened 2 years ago

jonathanpwang commented 2 years ago

https://github.com/scroll-tech/halo2-snark-aggregator/blob/7b9f4181a3e634806e72d6784fcdd255f19a7839/halo2-snark-aggregator-circuit/src/fs.rs#L132 Does this need to be Halo2VerifierCircuits<'_, Bn256, N>?

Also, I think vkey read/write does not work right now (known halo2 issue): can you merge the following PR into your halo2_proofs repo to resolve this? https://github.com/zcash/halo2/pull/661

OrestTa commented 2 years ago

@HAOYUatHZ