search

scroll-tech / halo2-snark-aggregator

halo2 ecc circuit
Apache License 2.0
114 stars 24 forks source link

(dont merge) Scroll dev 0920 #26

Closed lispc closed 2 years ago

lispc commented 2 years ago

merge this after GPU halo2 finsihed?

lispc commented 2 years ago

@zhenfeizhang do you have the push permission of this repo? It seems that master has updated, and after merging there are some new problem needed to be fixed, mostly OK => Value::known..

zhenfeizhang commented 2 years ago

I think so. I will fix those

lispc commented 2 years ago

@zhenfeizhang

I merged with scroll-dev-0818 and upgrade zkevm-circuits and fix building. I will test this branch with our testnet data. And if you have time you can have a review. (I run cargo clippy so the diff is large anda bit annoying... )

zhenfeizhang commented 2 years ago

In general LGTM.

OTOH I noticed that this repo does not have any CI. Is this intentional?

lispc commented 2 years ago

In general LGTM.

OTOH I noticed that this repo does not have any CI. Is this intentional?

should be added later https://github.com/scroll-tech/halo2-snark-aggregator/issues/27

after i upgrade halo2 for common-rs ( our all circuits repo ) and test it throughly we can merge this PR

lispc commented 2 years ago

common rs tests passed. So merge it now.