scroll-tech / mpt-circuit

MIT License
68 stars 30 forks source link

Require that row is enabled for non-poseidon lookups #92

Closed z2trillion closed 1 year ago

z2trillion commented 1 year ago

Previously, it was possible to satisfy lookups using rows that weren't enabled, meaning that most constraints were not being applied.

This fixes that for non-poseidon lookups.

This problem doesn't apply to poseidon lookups because the q_enable selector column of the poseidon table is part of the poseidon lookup and we check that it is 1.