search

scroll-tech / zkevm-circuits

MIT License
855 stars 369 forks source link

chore: typos in scroll-tech / zkevm-circuits #1219

Open alexanderblv opened 2 months ago

alexanderblv commented 2 months ago

https://github.com/scroll-tech/zkevm-circuits/blob/a08da074cecee804005bfd7eb3e46f02ac2ee5cc/zktrie/src/state.rs#L72

"is not need" should be "is not needed"

https://github.com/scroll-tech/zkevm-circuits/blob/a08da074cecee804005bfd7eb3e46f02ac2ee5cc/bus-mapping/src/rpc.rs#L118

"it's" should be "its"

https://github.com/scroll-tech/zkevm-circuits/blob/a08da074cecee804005bfd7eb3e46f02ac2ee5cc/gadgets/src/is_zero.rs#L4

"witnesses" should be "witnesses:"

https://github.com/scroll-tech/zkevm-circuits/blob/a08da074cecee804005bfd7eb3e46f02ac2ee5cc/gadgets/src/is_zero.rs#L17

"implementation" should be "implementing"

chenyuan1189 commented 2 months ago

no

alexanderblv commented 2 months ago

no

I don't quite understand what "No" means.

Kajko25 commented 2 months ago

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

alexanderblv commented 1 month ago

no

I don't quite understand what "No" means.

Neither do I... unfortunately it seems to me that this user had no intention of contributing anything to the discussion.... maybe someone from the team will speak up?

It would be good. Unfortunately, the issue has been open for a long time, but there is no reaction from the team. Maybe @DreamWuGit will respond

lispc commented 1 month ago

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

drstevenbrule commented 1 month ago

Disagree with your last one but made a PR for the sake of closing this out.

xyq-c-cpp commented 3 weeks ago

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

lispc commented 3 weeks ago

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

that's welcome!

xyq-c-cpp commented 3 weeks ago

thanks for the typos pointed. We may need to add some spelling check in CI to fix these and prevent typos in future. TODO.

can I do this TODO ? I would deliver it as soon as possible. thanks a lot. @lispc

that's welcome!

well, the enhanced PR had been merged. I think the other project repositories of scroll also need this TODO, how do you think about that? I would check these repositories whether this TODO exists,I would push this TODO to them if they don't have.I would refer to you in related PR.