scroll-tech / zkevm-circuits

MIT License
924 stars 387 forks source link

optimization of ccc #1272

Open lispc opened 5 months ago

lispc commented 5 months ago

Describe the feature you would like

  1. can we speedup RwMap::table_assignments_with_idx?
  2. for bus-mapping codecopy, avoid convert &[u8] to Bytecode. Bytecode is_code is not needed in copy circuit, so i think we can optimize this.
  3. optimize rlp circuit min_num_rows_block. most other circuits has an almost O(1) time of min_num_rows_block, while rlp circuit is full featured witgen, even with challenges.
  4. inside keccak_input, avoid recover_pk2

Additional context

.

FabioT81 commented 4 months ago

100% agree