scrollmapper / bible_databases

Bible versions and cross-reference databases.
1.01k stars 348 forks source link

Issue at verse 1043001 in BBE version #47

Open spodugu opened 3 years ago

spodugu commented 3 years ago

Hi, I found a issue in BBE version. The verse in Genesis 43:01, should be "Now the land was in bitter need of food." instead it is "And when the grain which they had got in Egypt was all used up, their father said to them, Go again and get us a little food."

May be due to this issue, Genesis 43: 34 is not present in the database. And there are multiple verses missing in BBE version.

But, I was wondering how the total count is still 31102.

scrollmapper commented 3 years ago

Thank you for mentioning this. I will look into it soon.

Jmainguy commented 3 years ago

Can confirm this is the case in at least the sqlite version provided.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_asv
Genesis 43:1
  And the famine was sore in the land.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_bbe
Genesis 43:1
  And when the grain which they had got in Egypt was all used up, their father said to them, Go again and get us a little food.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_dby
Genesis 43:1
  And the famine was grievous in the land.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_kjv
Genesis 43:1
  And the famine was sore in the land.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_wbt
Genesis 43:1
  \\43:2\\And it came to pass, when they had consumed the corn which they had brought from Egypt, their father said to them, Go again, buy us a little food.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_web
Genesis 43:1
  The famine was severe in the land.

[jmainguy@jmainguy-7410 bible]$ ./bible -number 1043001 -version t_ylt
Genesis 43:1
  And the famine `is' severe in the land;

incidentally a few verses in the t_wbt version have the verse number in the text returned. \\43:2\\, I will open a separate issue for that.

Jmainguy commented 3 years ago

I have opened https://github.com/scrollmapper/bible_databases/pull/60 as a way of discovering these errors sooner. I will have a separate PR to fix these inconsistencies soon.

Jmainguy commented 3 years ago

See comments in https://github.com/scrollmapper/bible_databases/pull/63 for a list of issues in the t_bbe translation. I believe it needs to be fixed in the mysql version first, and then proliferated out to the other versions from there. I am happy to do so by converting from the crosswire source if this project is okay with that. I would like to know how the json / xml / markdown / txt versions are generated to update those as well. Let me know if this would be accepted and how to proceed.