search

scrollmapper / bible_databases

Bible versions and cross-reference databases.
MIT License
1.05k stars 358 forks source link

t_wbt version has errors #57

Closed Jmainguy closed 3 weeks ago

Jmainguy commented 3 years ago

in sqlite at a minimum, the version has errors. A quick few I found while investigating another issue. Genesis 42-43 has the wrong number of verses.

Some verses have an escaped verse number in them. Example

Genesis 42:38
  And he said, My son shall not go down with you; for his brother is dead, and he is left alone: if mischief shall befall him by the way in which ye go, then will ye bring down my gray hairs with sorrow to the grave.

Genesis 42:39
  \\43:1\\And the famine was severe in the land.

Genesis 42 should only have 38 verses. Seems to be an issue with some of the translations and how they were generated.

Jmainguy commented 3 years ago

I have opened https://github.com/scrollmapper/bible_databases/pull/60 as a way of discovering these errors sooner. I will have a separate PR to fix these inconsistencies soon.

Jmainguy commented 3 years ago

Believe https://github.com/scrollmapper/bible_databases/pull/63 fixes this, by dropping the t_wbt table. This is to match what the mysql database has, and not include any extra translations. I believe t_wbt should be added to mysql database first, if people would like this in the other versions.

LeoBlanchette commented 3 weeks ago

Hello. I have addressed all of your concerns in the overhauled version of this repo. If you still require the old version of the repo, it is now the 2024 (legacy) branch.

This new repo has the Source of Truth you requested, and integrity checkers written in python to verify conversion went well.

Please note that the database schema has changed (why is explained in docs).

Thank you for your input. All should be well now. Please open any new issues if you find any.