search

scrom / Experiments

a NodeJS text adventure - deliberately coded badly to re-experience the pain of legacy code
http://mvta.herokuapp.com/
2 stars 0 forks source link

player.setLocation and player.examine duplicate too much code #438

Open scrom opened 8 years ago

scrom commented 8 years ago

the location mission processing code is completely duplicated - this needs factoring out.

scrom commented 8 years ago

the code is duplicated a third (!) time in missionController.initiateNewChildMissions it's at least described as deliberately duplicated there.

I have a feeling this third duplicate can be entirely removed but it'll need a lot of testing to be certain.