scrom / Experiments

a NodeJS text adventure - deliberately coded badly to re-experience the pain of legacy code
http://mvta.herokuapp.com/
2 stars 0 forks source link

mission.endgame needs fixing and a test written #447

Closed scrom closed 8 years ago

scrom commented 8 years ago

After a (difficult to reach) play test, mission.endgame throws an error:

ERROR! During game tick. (Useraction: "wait"). Error message/stack: ReferenceError: resultString is not defined Oct 23 12:15:18 mvta app/web.1: at Player.self.endGame (/app/js/server/player.js:4951:20) Oct 23 12:15:18 mvta app/web.1: at Mission.self.processReward (/app/js/server/mission.js:253:61) Oct 23 12:15:18 mvta app/web.1: at MissionController.self.processMissionState (/app/js/server/missioncontroller.js:120:40) Oct 23 12:15:18 mvta app/web.1: at MissionController.self.updateMissions (/app/js/server/missioncontroller.js:230:38) Oct 23 12:15:18 mvta app/web.1: at Map.self.updateMissions (/app/js/server/map.js:732:39)

scrom commented 8 years ago

fixed and supported with tests