search

scrom / Experiments

a NodeJS text adventure - deliberately coded badly to re-experience the pain of legacy code
http://mvta.herokuapp.com/
2 stars 0 forks source link

combining an item with multiple charges uses it all up #468

Open scrom opened 8 years ago

scrom commented 8 years ago

we should split off a single charge to combine.

this is particularly evident if carrying a bottle of milk and then picking up cereal - they auto-combine which incorrectly consumes all the milk

scrom commented 8 years ago

This is tricky - needs a lot of cleanup work in player.combine and artefact.combineWith (I think there's also an open issue that these are a mess - essentially these were written prior to the concept of "split" support so they do a bunch of manual stuff