interactive mode w/ssh no longer works

[GoogleCodeExporter]

I just built and installed 2.25 today, with genders and rcmd-ssh.  Since the 
install, I can no longer use pdsh in interactive mode:

[root@a4au-m1 tmp]# pdsh -w n002
pdsh> hostname
n002: Pseudo-terminal will not be allocated because stdin is not a terminal.

The "normal" way still works:

[root@a4au-m1 tmp]# pdsh -w n002 hostname -s
n002: a4au-n002

If I add "-v" to PDSH_SSH_ARGS_APPEND I can see that auth succeeds and it 
accepts my publickey, but then hangs - following is the last few lines I see:

n002: debug1: Authentication succeeded (publickey).
n002: debug2: fd 4 setting O_NONBLOCK
n002: debug2: fd 6 setting O_NONBLOCK
n002: debug1: channel 0: new [client-session]
n002: debug2: channel 0: send open
n002: debug1: Entering interactive session.
n002: debug2: callback start
n002: debug2: client_session2_setup: id 0
n002: debug2: channel 0: request shell confirm 0
n002: debug2: callback done
n002: debug2: channel 0: open confirm rwindow 0 rmax 32768
n002: debug2: channel 0: rcvd adjust 2097152

Original issue reported on code.google.com by justingw...@gmail.com on 31 Mar 2011 at 10:07

[GoogleCodeExporter]

Thanks for catching this, I can definitely reproduce it.
It looks like perhaps pdsh is dropping the command itself
from the cmdline when invoking ssh out of interactive mode.
I'll probably have a fix for you to test by tomorrow sometime.

Original comment by mark.gro...@gmail.com on 31 Mar 2011 at 11:47

• Changed state: Started

[GoogleCodeExporter]

Original comment by mark.gro...@gmail.com on 31 Mar 2011 at 11:48

• Added labels: Priority-High, Usability
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Actually I think I found the problem. Unfortunately a very silly mistake...
Can you try the attached patch?

Original comment by mark.gro...@gmail.com on 1 Apr 2011 at 12:02

Attachments:

• pdsh-rcmd-ssh-interactive.patch

[GoogleCodeExporter]

Patch worked great.  Thanks so much for the quick response.  

Original comment by justingw...@gmail.com on 1 Apr 2011 at 12:25

[GoogleCodeExporter]

This issue was updated by revision r1308.

Add simple test for failures in interactive mode with ssh module.

Original comment by mark.gro...@gmail.com on 1 Apr 2011 at 4:42

[GoogleCodeExporter]

This issue was closed by revision r1309.

Original comment by mark.gro...@gmail.com on 1 Apr 2011 at 4:42

• Changed state: Fixed