search

scroot / gopacket

Automatically exported from code.google.com/p/gopacket
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

const in layers/winsock.go are already defined in layers/enum.go #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Setup windows golang environment
2. with winpcap developer pack 4.1.2
3. build a program

What is the expected output? What do you see instead?
{{{
# code.google.com/p/gopacket/layers
testproj\src\code.google.com\p\gopacket\layers\winsock.go:15: 
ProtocolFamilyIPv4 redeclared in this block
        previous declaration at testproj\src\code.google.com\p\gopacket\layers\enums.go:182
testproj\src\code.google.com\p\gopacket\layers\winsock.go:18: 
ProtocolFamilyIPv6BSD redeclared in this block
        previous declaration at testproj\src\code.google.com\p\gopacket\layers\enums.go:185
testproj\src\code.google.com\p\gopacket\layers\winsock.go:19: 
ProtocolFamilyIPv6FreeBSD redeclared in this block
        previous declaration at testproj\src\code.google.com\p\gopacket\layers\enums.go:186
testproj\src\code.google.com\p\gopacket\layers\winsock.go:20: 
ProtocolFamilyIPv6Darwin redeclared in this block
        previous declaration at testproj\src\code.google.com\p\gopacket\layers\enums.go:187
testproj\src\code.google.com\p\gopacket\layers\winsock.go:21: 
ProtocolFamilyIPv6Linux redeclared in this block
        previous declaration at testproj\src\code.google.com\p\gopacket\layers\enums.go:188
}}}

What version of the product are you using? On what operating system?
`go get code.google.com/p/gopacket`

Please provide any additional information below.

{{{
diff --git a/layers/winsock.go b/layers/winsock.go
index 9e716c8..66f9539 100644
--- a/layers/winsock.go
+++ b/layers/winsock.go
@@ -11,12 +11,3 @@ package layers
 // #include <WinSock.h>
 import "C"

-const (
-       ProtocolFamilyIPv4 ProtocolFamily = C.AF_INET
-       // BSDs use different values for INET6... glory be.  These values taken
-       // tcpdump 4.3.0.
-       ProtocolFamilyIPv6BSD     ProtocolFamily = 24
-       ProtocolFamilyIPv6FreeBSD ProtocolFamily = 28
-       ProtocolFamilyIPv6Darwin  ProtocolFamily = 30
-       ProtocolFamilyIPv6Linux   ProtocolFamily = 10
-)
}}}

Original issue reported on code.google.com by Hiroaki.Kawai@gmail.com on 16 Jun 2014 at 4:49

GoogleCodeExporter commented 9 years ago 
Rolling out this fix now.

Original comment by gconnell@google.com on 16 Jun 2014 at 4:51