scroot / gopacket

Automatically exported from code.google.com/p/gopacket
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

pull-request for pcapgo file reader #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hello. I implemented a native go pcap reader, parallel to the existing native 
go writer.

It supports 2.4 file format and decodes little and big endian.

GIT URL is https://code.google.com/r/damjancvetko-pcapgo-read-gopacket/

(sorry, did not find other way to submit pull request)

Original issue reported on code.google.com by damjan.cvetko@gmail.com on 18 Sep 2014 at 12:37

GoogleCodeExporter commented 9 years ago
Sorry to take a long time responding to this, and thanks so much for the 
contribution.  Do you think it would be possible to modify this to accept all 
valid pcap variants (little/big-endian with all timestamp variants)?

Original comment by gconnell@google.com on 23 Oct 2014 at 3:17

GoogleCodeExporter commented 9 years ago
Sure. both endians of micro format are handled, I can add also nano formats.
I'll also change the names of the consts to avoid confisuin (pcapgo is actualy 
writing micro format, not nano...)

Original comment by damjan.cvetko@gmail.com on 23 Oct 2014 at 9:40

GoogleCodeExporter commented 9 years ago
There.
Added pcapgo support for micro/nano and little/big endian support (and a new 
test).
Asside from that, great work, gopacket is awesome!

Original comment by damjan.cvetko@gmail.com on 23 Oct 2014 at 10:07

GoogleCodeExporter commented 9 years ago
I just realized you added me as committer. I pushed all changes to branch 
"damjan". Merge to master as you see fit :)

Original comment by damjan.cvetko@gmail.com on 29 Oct 2014 at 8:45