search

scroot / gopacket

Automatically exported from code.google.com/p/gopacket
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Code review request #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: bgreen/sflow

Purpose of code changes on this branch:

Adds decoding layer for SFlow version 5. It includes the more widely-used 
sample types. Some sample types are not supported.

When reviewing my code changes, please focus on:

It's not very complicated code, so I guess just be sure it follows the overall 
philosophy and has good style, etc. I'm not a developer, so I'm sure it has 
some issues.

After the review, I'll merge this branch into:

Not sure about this... I'll leave the merge up to you if possible.

Original issue reported on code.google.com by bgreen@newrelic.com on 24 Oct 2014 at 5:31

GoogleCodeExporter commented 9 years ago

Original comment by gconnell@google.com on 14 Nov 2014 at 4:36

GoogleCodeExporter commented 9 years ago 
I believe I'm good with the code as it exists now in the branch.

Is there anything else you'd like to do before we merge it into master?

Also, would you like your name in AUTHORS, and if so, how would you like it to 
appear?

Original comment by gconnell@google.com on 8 Jan 2015 at 11:46

GoogleCodeExporter commented 9 years ago 
I'm good with the code as is. Please include me as Bill Green 
<bgreen@newrelic.com>.  I appreciate all the hand-holding with this, it was 
very instructive for me, thank you.

Original comment by bgreen@newrelic.com on 8 Jan 2015 at 11:52

GoogleCodeExporter commented 9 years ago 
Pushed up to master, added tag v1.1.10

Original comment by gconnell@google.com on 8 Jan 2015 at 11:57