scross01 / prometheus-klipper-exporter

Prometheus Exporter for Klipper
MIT License
48 stars 10 forks source link

Merge similar metrics into single ones with labels. #10

Closed Cova closed 1 year ago

Cova commented 1 year ago

Metrics like klipper_temperaturefan_speed, or klipper_temperaturesensor_temperature, should be using labels rather than uniquely named metrics. I have a bunch of printers with extra fans/thermistors in them in various places, and it is resulting in a very large number of metrics which mostly have empty values as that sensor only exists in a single machine.

I would much prefer just a klipper_temperature_sensor{sensor="*"} style of metric to work with.

scross01 commented 1 year ago

Made some initial changes to address this in the metrics_with_labels branch.

scross01 commented 1 year ago

Fixed in v0.7.0