scrtlabs / EthereumBridgeFrontend

Frontend for the Ethereum<>Secret Network bridge
Other
9 stars 22 forks source link

"Learn More" about SEFI tokens link goes to swap page #138

Open secretchaingirl opened 3 years ago

secretchaingirl commented 3 years ago

I'm thinking this should go to a page explaining about SEFI tokens instead of the swap page.

image

secretchaingirl commented 3 years ago

Same for clicking on "Claim Sefi", there's a "Read More" link there too.

image

cankisagun commented 3 years ago

Regarding Laura's first msg - cashback tokens are not functional at the moment and will not be by Monday. Let's just add "Cashback tokens are currently under development"

Let's say "Claim Genesis SEFI" - not SeFi -> we need all caps. We can change when cashback is enabled

I am having Keplr issues image

More Keplr issues image

There's a decimal point issue with ETH rewards (1/100th of the amount is shown) image

image

codebydavidrl commented 3 years ago

Hi guys, regarding the info icon for now is hidden, can be displayed it when chasback tokens are functional.

@cankisagun we also made some changes this Keplr and MetaMask issues should not be a problem any more.

Here is the link were this changes were deployed.

https://swap-app.onrender.com/swap

cankisagun commented 3 years ago

@David-Sod thanks a lot. Can we add a secret logo in the keplr part so that the addresses are aligned left for 0x (ethereum) and secret network image

This still needs fixing. 89.15 should be 8915 image

codebydavidrl commented 3 years ago

@cankisagun just added the scrt icon and fixed that decimal point issue. Also add the "Secure By" icon to the page.

You can check the changes in the link above.

I'll be pending of feedback.

cankisagun commented 3 years ago

@David-Sod Unclaimed amount is not accurate + we have SEFI twice now. I suggest we take out unclaimed + sefi rows until we add cashback - we can then activate those back again to the design image

The rest looks great

codebydavidrl commented 3 years ago

That's a great idea, this rows are hidden now, with all resolved I'm moving this issue to Done

cankisagun commented 3 years ago

Perfect - I'm adding a tag "cashback" as this needs re-opening when cashback is enabled