scrtlabs / EthereumBridgeFrontend

Frontend for the Ethereum<>Secret Network bridge
Other
9 stars 22 forks source link

After providing liquidity my pool share % when to "NaN" #142

Open secretchaingirl opened 3 years ago

secretchaingirl commented 3 years ago

Sorry to be a pain, but I bugs me when I see "NaN" is displayed in such a nice UI :-P.

image

Right after the "Provide" transaction completed, the UI updated and that's when I noticed the NaN % of pool share.

cankisagun commented 3 years ago

is this a refresh issue @Cashmaney

codebydavidrl commented 3 years ago

We haven't touched that part of the code. I reviewed the variable that's been displayed though and noticed an expected Big Number is being returned as null from the backend.

2021-04-26_12h36_47

We can 2 two things:

cankisagun commented 3 years ago

can we just show "-"

secretchaingirl commented 3 years ago

I can confirm I'm now seeing "-" for the value of "Your Current Share of Pool." But I was expecting to see some value > 0.

This may become a consistent support issue from users if they don't get the UI feedback on their current share of the pool.

cankisagun commented 3 years ago

My bad - I thought we were getting NaN when there's no liquidity. @lauraweindorf can you pls confirm you have liquidity in the pair (that's not staked in an earn pool) and you are still seeing "-"?

secretchaingirl commented 3 years ago

no worries @cankisagun!

Okay, yeah so here's a snapshot just before I'm providing liquidity for the SEFI/sSCRT pair:

image

This is the successful screen, where I'm expecting to see my percent of the pool to be > 0:

image

Maybe I'm misunderstanding something though?

I reloaded the "Provide" page to see if it was a refresh issue, but it still says my share of the pool is "-".

And then when I go to the "Withdraw" page to see what that says my total pooled tokens are >244 yet the # of tokens for each is 0, and my pool share is also showing 0%.

image

cankisagun commented 3 years ago

@David-Sod these seem to be working on the current swap UI - I think you guys must be ommitting something

image

image

We gotta get the actual numbers "-" is not going to work. I misread the prev. issue

Can you pls check with @Cashmaney

codebydavidrl commented 3 years ago

Yeah, when we separated the components and during the process forget a function, now this issues should be fixed.