search

scrtlabs / SafeTrace

Privacy preserving voluntary Covid-19 self-reporting platform. Share your location history and status, get alerts you are in high risk areas and identify high risk regions
MIT License
127 stars 27 forks source link

UI updates & parse script #50

Open alaaltoros opened 4 years ago

alaaltoros commented 4 years ago

PR related to issue #21 (Front-End UI for MVP)

It includes the following:

Basic UI Login/logout with google Location data parse script I Will be updating it as soon as other parts are ready.

P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console.

ainsleys commented 4 years ago

Hey @alaaltoros can you add a description to this PR explaining what it is?

alaaltoros commented 4 years ago

PR related to issue #21 (Front-End UI for MVP)

It includes the following:

I Will be updating it as soon as other parts are ready.

P.S. The login/logout functionality requires google client id (check the README.md) and the upload button will output the parsed data in the console.

alaaltoros commented 4 years ago

Added report and file upload basic functionality

alaaltoros commented 4 years ago

Hello @lacabra, I updated the README.md file and the directory structure. Let me know if you can get the client to run or if you have any other comments or doubts. Please note that the backend is included in a different repository and a different pull request (I added a URL in the README.md file)

alaaltoros commented 4 years ago

Added the Results page with formatted data. However, I could not test with a real response from findMatches endpoint of Enclave; I received no matches and could not upload report new results because of the CORS error.

cmalfesi commented 4 years ago

@alaaltoros I have tested your last changes and in general, it looks good. Regarding the issue that returns CORS error, I have done some tests and I see that the problem occurs when there are 2 consecutive calls to the Enclave endpoints. If I execute one only it works. I think the problem is related to the promise or await functions.

cmalfesi commented 4 years ago

@alaaltoros I have an improvement for the frontend to get better behavior with consecutive calls to the enclave endpoints. We need to separate addPersonalData and findMatch in different async functions. This solves the CORS problem. I'll send you the required changes.

assafmo commented 4 years ago

@alaaltoros can you resolve the conflicts? Also waiting for @cmalfesi CORS fixes in order to merge this.

alaaltoros commented 4 years ago

@assafmo conflicts resolved!

assafmo commented 4 years ago

Still seeing conflicts in UIcode/client/package-lock.json and UIcode/client/yarn.lock. You can remove the one you don't use and rebuild the one you use.